PHP 8.1 compatibility #310
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
arthurkushman/querypath seems to be abandonded as well now, see arthurkushman/querypath#12. To use this in a project, you can do composer require gravitypdf/querypath in a project and it should replace the others. |
|
I've required the new 8.1 package directly on this PR, I'll push a release on packagist with the replace directive as well for this package |
|
Published on https://packagist.org/packages/deimosindustries/lullabot-amp |
abhineshdhiman-srijan
approved these changes
Feb 6, 2023
|
Any news.. ? |
|
@yesworld no idea, sadly I am not a maintainer of this repo and I would need one of the owners to approve and merge the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds php 8 compatibility as asked on #302 also solves some waterfall problem on other libraries requiring different forks of the
querypath/querypathlibrary.